[Shipping labels] Upsert create packages response after saving packages remotely #14710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #14522
⚠️ Depends on #14690 ⚠️
Description
This PR caches the saved packages received from remote after saving (starring) a package, so we can fetch those saved packages from storage during Woo Shipping label creation:
WooShippingStore.createPackage(siteID:customPackage:predefinedOption:completion:)
to upsert the response received from remote:WooShippingCreatePackageResponse
in the background by handling the custom packages and saved predefined package IDs in that response.WooShippingCreatePackageResponse
.WooShippingAddPackageViewModel
, where we were previously doing this transformation.)Testing information
Confirm unit tests pass. You can also confirm the packages response continues to work as expected:
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: