Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Theme URI to point to Woo Marketplace page #2104

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Update Theme URI to point to Woo Marketplace page #2104

merged 2 commits into from
Jul 12, 2023

Conversation

danielwrobert
Copy link
Contributor

Previously the Theme URI was pointing to a retired landing page.

This update adjusts the URI to point to the current theme page in the Woo products marketplace.

How to test the changes in this Pull Request:

  1. Confirm link to Theme URI has been updated to point to the Woo Marketplace Storefront page.
  2. Confirm there are no remaining links to the retired landing page.

Changelog

Fix – Theme URI now points to Storefront page in Woo Marketplace. All links to retired theme landing page have also been updated.

@danielwrobert
Update the Theme URI to use current theme page.
b1f1f19 
Previously the Theme URI was pointing to a retired landing page.
This update adjusts the URI to point to the current theme page in
the Woo products marketplace.
@danielwrobert
Update link to theme page throughout theme files.
01a9bd2 
Replace instanecs of the retired theme landing page link with the link
to the Storefront theme in the Woo Marketplace.
@danielwrobert danielwrobert self-assigned this Jul 11, 2023
@danielwrobert danielwrobert marked this pull request as ready for review July 11, 2023 18:46
@danielwrobert danielwrobert added the status: needs review PR that needs review label Jul 11, 2023
danieldudzic
danieldudzic approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@danieldudzic danieldudzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to find any outdated woocommerce.com/storefront links in the Storefront repo.

I found some references on wp.com via OpenGrok (for example some onboarding emails) but I'm pretty sure we are no longer using them, plus woocommerce.com/storefront redirects to woocommerce.com/product-category/themes so this shouldn't be an issue.

@github-actions github-actions bot added status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. and removed status: needs review PR that needs review labels Jul 11, 2023
@danieldudzic danieldudzic merged commit 56714d9 into trunk Jul 12, 2023
@danieldudzic danieldudzic deleted the update/theme-uri branch July 12, 2023 13:16
@danielwrobert
Copy link
Contributor Author

@danieldudzic Yeah, there are some references to that outside of this theme (WC Core, for example) but my focus here was removing all of the links within the theme. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldudzic danieldudzic danieldudzic approved these changes

Assignees

@danielwrobert danielwrobert

Labels
status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielwrobert @danieldudzic