firefox: build from source tarball instead of hg #40036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OddBloke
force-pushed
the
oddbloke/firefox
branch
from
796090e to
19c4015
Compare
octo-sts
bot
added
the
bincapz/pass
EyeCantCU
reviewed
Jan 21, 2025
EyeCantCU
reviewed
Jan 21, 2025
OddBloke
force-pushed
the
oddbloke/firefox
branch
2 times, most recently
from
5612041 to
2d5388a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
The Mercurial `_RELEASE` tag seems to be created some time after the release has been made public on ftp.mozilla.org. release-monitoring.org uses ftp.mozilla.org as its source of truth, which generally means that we detect the new version and attempt to build the release before the tag has been published, resulting in build failures. Switching to the release tarball should avoid manual intervention for every Firefox release, thereby decreasing the latency from upstream release to availability in Wolfi. It has the additional advantage of future-proofing us against the planned migration to GitHub for development (though once that's occurred, we should examine whether consuming from GitHub directly would be appropriate). (`wget` is probably also faster than `hg clone`, though I haven't confirmed this.)
OddBloke
force-pushed
the
oddbloke/firefox
branch
from
2d5388a to
e8063f8
Compare
EyeCantCU
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mercurial
_RELEASEtag seems to be created some time after the release has been made public on ftp.mozilla.org. release-monitoring.org uses ftp.mozilla.org as its source of truth, which generally means that we detect the new version and attempt to build the release before the tag has been published, resulting in build failures.Switching to the release tarball should avoid manual intervention for every Firefox release, thereby decreasing the latency from upstream release to availability in Wolfi. It has the additional advantage of future-proofing us against the planned migration to GitHub for development (though once that's occurred, we should examine whether consuming from GitHub directly would be appropriate). (
wgetis probably also faster thanhg clone, though I haven't confirmed this.)