Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson fixes #27

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Meson fixes #27

merged 4 commits into from
Jan 8, 2024

Conversation

ErikReider
Copy link
Member

@ErikReider ErikReider commented Jan 6, 2024

Fixes: #26

Todo:

  • Add back xkbcommon dep
  • Move some headers into scenefx dir
    • Shadow struct
    • custom wlr_scene struct
    • All of the fx_renderer/pass headers?
  • Fix not being able to build statically due to conflicting functions

@ErikReider ErikReider self-assigned this Jan 6, 2024
@ErikReider ErikReider changed the title Added back xkbcommon dep. Fixes tinywl compilation Meson fixes Jan 6, 2024
@ErikReider ErikReider force-pushed the add_back_xkbcommon_dep branch from 317e7a2 to ee34a5d Compare January 6, 2024 20:44
@ErikReider ErikReider marked this pull request as ready for review January 6, 2024 21:57
@ErikReider
Copy link
Member Author

I've tested it and everything works as expected, even installed it as a library on my system :)

The only question mark is how we're going to expose the fx_renderer. Everything in the renderer is exposed atm which might not be ideal. Could be useful for SwayFX though?

Any input?

@WillPower3309
Copy link
Member

I've tested it and everything works as expected, even installed it as a library on my system :)

The only question mark is how we're going to expose the fx_renderer. Everything in the renderer is exposed atm which might not be ideal. Could be useful for SwayFX though?

Any input?

Discussed on discord but mentioning here too for anyone following the issue on GitHub, for now we will be exposing the bare minimum functions for SwayFX to use. We can always expose more functions but can't take them away (without annoying our users) so we're starting small.

@ErikReider ErikReider force-pushed the add_back_xkbcommon_dep branch from 7d91a74 to cc83f41 Compare January 7, 2024 21:19
@ErikReider
Copy link
Member Author

Should be ready now

@ErikReider ErikReider merged commit b875d71 into main Jan 8, 2024
@lidgnulinux
Copy link

For the example tinywl, I think the Makefile need little additional :

$(shell pkg-config --cflags --libs scenefx) 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example tinywl : missing headers ?
3 participants