Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(hi): update environmental-impact.md #1133

Merged
merged 4 commits into from
Nov 24, 2023
Merged

i18n(hi): update environmental-impact.md #1133

merged 4 commits into from
Nov 24, 2023

Conversation

at-the-vr
Copy link
Member

@at-the-vr at-the-vr commented Nov 24, 2023 •
edited
Loading

Description

  • translate environmental-impact.mdx in hindi language

Preview Deployment: Link

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6cdc83b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Nov 24, 2023 2:02pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Nov 24, 2023
HiDeoo
HiDeoo requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist and except a very few link changes, everything looks good to me 👍

docs/src/content/docs/hi/environmental-impact.md Outdated Show resolved Hide resolved
docs/src/content/docs/hi/environmental-impact.md Outdated Show resolved Hide resolved
at-the-vr and others added 2 commits November 24, 2023 18:51
@at-the-vr @HiDeoo
update path for assets documentation
d04c9aa 
suggestion from Hideoo

Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
@at-the-vr @HiDeoo
chore: Update path for astro islands documentation
1c36ef9 
suggestion from hideoo

Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
@at-the-vr
Copy link
Member Author

Suggestions applied 😁. Now, I have to keep some Reminder Note everytime i translate the links 😅

HiDeoo
HiDeoo approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fixes, really appreciated 🌟

@HiDeoo HiDeoo merged commit feb3d7d into withastro:main Nov 24, 2023
6 checks passed
@at-the-vr at-the-vr deleted the atv/i18n/hi/env-impact branch December 9, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@at-the-vr @HiDeoo