Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@astrojs/prefetch]: Prevent prefetching current page #5009

Merged
merged 5 commits into from
Oct 7, 2022
Merged

[@astrojs/prefetch]: Prevent prefetching current page #5009

merged 5 commits into from
Oct 7, 2022

Conversation

panwauu
Copy link
Contributor

@panwauu panwauu commented Oct 7, 2022

Changes

Testing

  • Added prefetch link to "/" to the test page
  • Added tests to check that the path "/" is only requested once
  • Refactored the unnecessary use of await keyword

Docs

As this is a bugfix, no docs change is needed.

Fixes #4963

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 23c4903

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 7, 2022
@panwauu
Copy link
Contributor Author

panwauu commented Oct 7, 2022

Failed test seems unrelated

@matthewp matthewp merged commit 92b27e9 into withastro:main Oct 7, 2022
@astrobot-houston astrobot-houston mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@astrojs/prefetch] Prevent prefetching current page
2 participants
@panwauu @matthewp