Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure basic event logging #728

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Ensure basic event logging #728

merged 1 commit into from
Dec 7, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Dec 7, 2020

Similar to #725. If the config file can't be loaded at all, writes a log entry using source "Windows Service Wrapper".

@nxtn nxtn added this to the 3.x milestone Dec 7, 2020
@nxtn nxtn requested a review from oleg-nenashev as a code owner December 7, 2020 11:45
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nxtn nxtn merged commit cb8ded2 into v3 Dec 7, 2020
@nxtn nxtn deleted the eventlog branch December 7, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants