Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand environment variables in YAML extensions #677

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

buddhikac96
Copy link
Contributor

Fixes #667

  • Expand environment variable in extension configurations

@nxtn nxtn added this to the 2.x milestone Sep 2, 2020
@nxtn nxtn changed the title WInSW extension : Environment variable expansion WinSW extension : Environment variable expansion Sep 25, 2020
@winsw winsw deleted a comment from codecov bot Dec 28, 2020
@nxtn nxtn force-pushed the extension_env_expansion branch from 43c615c to 200b14f Compare December 28, 2020 12:06
@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #677 (43c615c) into master (2c86e14) will increase coverage by 6.89%.
The diff coverage is 62.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   36.63%   43.52%   +6.89%     
==========================================
  Files          37       34       -3     
  Lines        3407     3274     -133     
==========================================
+ Hits         1248     1425     +177     
+ Misses       2159     1849     -310     
Impacted Files Coverage Δ
src/WinSW.Core/Configuration/YamlConfiguration.cs 53.86% <43.47%> (-0.41%) ⬇️
src/WinSW.Plugins/RunawayProcessKillerExtension.cs 18.51% <85.71%> (+0.77%) ⬆️
src/WinSW.Core/Util/ConfigHelper.cs 91.17% <100.00%> (+0.85%) ⬆️
src/WinSW.Plugins/SharedDirectoryMapperConfig.cs 88.00% <100.00%> (+0.50%) ⬆️
src/WinSW.Core/Native/Service.cs 39.50% <0.00%> (-5.30%) ⬇️
src/WinSW.Core/LogAppenders.cs 10.55% <0.00%> (-0.90%) ⬇️
src/WinSW.Core/Native/Throw.cs 0.00% <0.00%> (ø)
src/WinSW.Core/Native/Security.cs 0.00% <0.00%> (ø)
src/WinSW.Core/ServiceDescriptorYaml.cs 38.46% <0.00%> (ø)
src/WinSW.Core/Extensions/WinSWExtensionManager.cs 58.22% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c86e14...242460a. Read the comment docs.

@nxtn nxtn added the bug label Dec 28, 2020
@nxtn nxtn changed the title WinSW extension : Environment variable expansion Expand environment variables in YAML extensions Dec 28, 2020
@nxtn nxtn removed their request for review December 28, 2020 12:09
@nxtn nxtn force-pushed the extension_env_expansion branch from 200b14f to 242460a Compare December 28, 2020 12:10
@nxtn nxtn merged commit 027a8d3 into winsw:master Dec 28, 2020
@nxtn nxtn linked an issue Dec 28, 2020 that may be closed by this pull request
@nxtn nxtn modified the milestones: 2.x, 2.11.0 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runaway Process Killer doesn't expand %BASE%
2 participants