Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customize command #615

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Add customize command #615

merged 1 commit into from
Aug 5, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jul 30, 2020

Fixes #199

Usage

winsw customize -o <output> --manufacturer <manufacturer>

There is currently a limitation on the new name:

const int minLength = 12;
const int maxLength = 15;

/cc @aminjam

@nxtn nxtn added this to the 3.x milestone Jul 30, 2020
@nxtn nxtn requested a review from oleg-nenashev as a code owner July 30, 2020 11:38
@nxtn nxtn linked an issue Jul 30, 2020 that may be closed by this pull request
Changing Assembly Information for created services #199
Closed
oleg-nenashev
oleg-nenashev approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see anything wrong with the code, and it looks to be well contained.
Ideally the code should explicitly invalidate code signing if present (it would be broken anyway due to the checksum change), and to require users to re-sign the executable on their own if they need signing

@oleg-nenashev
Copy link
Member

Would it also make sense to introduce a new unit test which operates with a WinSW.exe copy? It would not be a full integration test, but it would provide some coverage

@nxtn
Copy link
Contributor Author

nxtn commented Aug 4, 2020 •
edited
Loading

Ideally the code should explicitly invalidate code signing if present (it would be broken anyway due to the checksum change), and to require users to re-sign the executable on their own if they need signing

I'll make it clear in the command description. Not easy to play with signatures in our codes.

Would it also make sense to introduce a new unit test which operates with a WinSW.exe copy?

Certainly.

@nxtn nxtn merged commit 2a576e1 into winsw:v3 Aug 5, 2020
@nxtn nxtn deleted the v3-customize branch August 5, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
needs-review new-feature
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.

Changing Assembly Information for created services
2 participants
@nxtn @oleg-nenashev