Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise docs for 3.0.0-alpha.2 #594

Merged
merged 18 commits into from
Jul 28, 2020
Merged

Revise docs for 3.0.0-alpha.2 #594

merged 18 commits into from
Jul 28, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jul 22, 2020 •
edited
Loading

  • Add prestart/poststart/prestop/poststop settings
  • Remove <waithint> and <sleeptime>
  • Add refresh command
  • New command-line interface

@nxtn nxtn added this to the 3.x milestone Jul 22, 2020
@nxtn nxtn marked this pull request as ready for review July 25, 2020 09:17
@nxtn nxtn requested a review from oleg-nenashev as a code owner July 25, 2020 09:17
@nxtn
Copy link
Contributor Author

nxtn commented Jul 27, 2020 

  X WinSW.Tests.MainTest.ShouldNotPrintLogsForStatusCommand [3ms]
  Error Message:
   Assert.Equal() Failure
          ↓ (pos 0)
Expected: NonExistent\r\n
Actual:   Stopped\r\n
          ↑ (pos 0)
  Stack Trace:
     at WinSW.Tests.MainTest.ShouldNotPrintLogsForStatusCommand() in d:\a\1\s\src\WinSW.Tests\MainTest.cs:line 48

There may be a race condition somewhere. Not our bug.

@nxtn
Copy link
Contributor Author

nxtn commented Jul 27, 2020

Merging to release. Review comments will be resolved in #608.

@nxtn nxtn merged commit 1b2365a into v3 Jul 28, 2020
@nxtn nxtn deleted the v3-docs branch July 28, 2020 00:35
@nxtn nxtn mentioned this pull request Jul 31, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev oleg-nenashev is a code owner

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.
1 participant
@nxtn