Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven Build flow should pick releases from GitHub or NuGet #80

Closed
oleg-nenashev opened this issue Feb 1, 2015 · 4 comments · Fixed by #162
Closed

Maven Build flow should pick releases from GitHub or NuGet #80

oleg-nenashev opened this issue Feb 1, 2015 · 4 comments · Fixed by #162
Assignees
@oleg-nenashev
Labels
build-flow
Milestone
2.0.0

Comments

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Feb 1, 2015 •
edited
Loading

A correct Assembly version is required to track dependencies and to show it in CLI.

TODOs:

  • Manually fix the version for winsw-1.x
  • Adjust build flows to check/update Assembly info and pow.xml

Required for #78
@oleg-nenashev oleg-nenashev self-assigned this Feb 1, 2015
oleg-nenashev added a commit to oleg-nenashev/winsw that referenced this issue Feb 1, 2015
@oleg-nenashev
Add "version" and "help", handle unsupported commands
4a532a7 
This rework minimally impacts the project structure

Resolves winsw#78 and winsw#46
Related to winsw#80

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
@oleg-nenashev oleg-nenashev mentioned this issue Feb 1, 2015
Merged
oleg-nenashev added a commit to oleg-nenashev/winsw that referenced this issue Feb 1, 2015
@oleg-nenashev
Add "version" and "help", handle unsupported commands
e290434 
This rework minimally impacts the project structure

Resolves winsw#78 and winsw#46
Related to winsw#80

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
oleg-nenashev added a commit to oleg-nenashev/winsw that referenced this issue Feb 2, 2015
@oleg-nenashev
Add "version" and "help", handle unsupported commands (PR winsw#81)
3ae6ffa 
Changes summary:
* Add "version" and "help" commands
* Return error on the unsupported command
* Add CLITestHelper to simplify the testing of the service CLI
* Add unit-tests for the new functionality

Resolves winsw#78 and winsw#46
Related to winsw#80

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
@oleg-nenashev oleg-nenashev removed the bug label Feb 2, 2015
@oleg-nenashev oleg-nenashev added this to the winsw-2.0 milestone Feb 2, 2015
@oleg-nenashev
Copy link
Member Author

The bug has been fixed in winsw-1.17
For winsw-2.0 it's just an improvement case

@mrjoel
Copy link

mrjoel commented Aug 17, 2016

This was updated for 1.18, however the 1.19 release still misreports 1.18 as the assembly version...

@oleg-nenashev
Copy link
Member Author

Fixed in 2.19.1 BTW it's still a risk

@oleg-nenashev oleg-nenashev changed the title WinSW Assembly version differs from pom.xml POM release should fail if WinSW Assembly version differs from pom.xml Nov 26, 2016
@oleg-nenashev oleg-nenashev changed the title POM release should fail if WinSW Assembly version differs from pom.xml Maven Build flow should pick releases from GitHub or NuGet Dec 10, 2016
oleg-nenashev added a commit that referenced this issue Dec 10, 2016
@oleg-nenashev
Issue #80 - Maven builds now picks releases from GitHub and verifies …
9c13374 
…WinSW versions
@oleg-nenashev oleg-nenashev mentioned this issue Dec 10, 2016
Merged
3 tasks
@oleg-nenashev
Copy link
Member Author

So the new flow has been merged. Maven release attempts will fail if the version differs from the WinSW release

@nxtn nxtn modified the milestones: winsw-2.0, 2.0.1, 2.0.0 Mar 25, 2020
@winsw winsw locked as resolved and limited conversation to collaborators Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@oleg-nenashev oleg-nenashev

Labels
build-flow
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Maven POM update towards 2.0 oleg-nenashev/winsw
3 participants
@mrjoel @oleg-nenashev @nxtn