Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored themes management #1515

Merged
merged 18 commits into from
Oct 4, 2022
Merged

Refactored themes management #1515

merged 18 commits into from
Oct 4, 2022
+512 −409

Conversation

mrizzi
Copy link
Member

@mrizzi mrizzi commented Sep 19, 2022 •
edited
Loading

  • concurrent builds of all the themes, no need to run multiple builds anymore
  • windup theme enabled by default. To disable it run with option -DskipThemeWindup
  • other themes can be built using profiles (i.e. -P<theme_name>)
  • removed the GreetingListener for blocking issues with the themes and reported the log into boostrap
  • added some Freemarker methods in order to have just one About page and navigation bar
  • changed tests accordingly

This was referenced Sep 19, 2022
Merged
Merged
@mrizzi mrizzi mentioned this pull request Sep 20, 2022
Closed
mrizzi added 10 commits September 21, 2022 09:11
@mrizzi mrizzi mentioned this pull request Sep 22, 2022
Merged
@mrizzi mrizzi mentioned this pull request Sep 29, 2022
Merged
mrizzi
mrizzi commented Oct 4, 2022
View reviewed changes
Copy link
Member Author

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with daily snapshot builds and other themed builds.
All good, so going to merge it now.

@mrizzi mrizzi merged commit 2bc507e into windup:master Oct 4, 2022
@mrizzi mrizzi deleted the refactored-themes branch October 4, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mrizzi