Support proxying images with no provided intermediate cert #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 88.04% 88.19% +0.14%
==========================================
Files 6 6
Lines 686 542 -144
==========================================
- Hits 604 478 -126
+ Misses 56 36 -20
- Partials 26 28 +2
Continue to review full report at Codecov.
|
…e missing intermediate certs
willnorris
force-pushed
the
aia-cert-chain
branch
from
fd7e61d to
2d5c717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run across several customer issues over the last few days where the provider sending them content is serving images from a domain without their intermediate cert in the chain. This leads to this wonderful error while trying to load the image:
openssldoesn't complete intermediate cert chains (and neither doesnet/http), instead opting to toss it off to the app to take care of. This isn't an issue in the browser (or cURL) because they take care of finishing out the cert and verifying it (and Windows does, funnily enough -- macOS and Linux do not).But! Someone has already solved this issue for
net/http: https://github.com/fcjr/aia-transport-goThis PR swaps the
http.DefaultTransportstruct for one provided byaia-transport-gothat can finish fetching and verifying intermediate certificates.(I don't have an example image unfortunately, I've been troubleshooting with customer-provided images as they write in.)