Support proxying images with no provided intermediate cert #241
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run across several customer issues over the last few days where the provider sending them content is serving images from a domain without their intermediate cert in the chain. This leads to this wonderful error while trying to load the image:
openssl
doesn't complete intermediate cert chains (and neither doesnet/http
), instead opting to toss it off to the app to take care of. This isn't an issue in the browser (or cURL) because they take care of finishing out the cert and verifying it (and Windows does, funnily enough -- macOS and Linux do not).But! Someone has already solved this issue for
net/http
: https://github.com/fcjr/aia-transport-goThis PR swaps the
http.DefaultTransport
struct for one provided byaia-transport-go
that can finish fetching and verifying intermediate certificates.(I don't have an example image unfortunately, I've been troubleshooting with customer-provided images as they write in.)