Feat/right click #92
Merged
Feat/right click #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tibotiber - this is a good feature to have. Can you remove all the build files and only keep the ones in "src"? It will be easier for me to review. I'll rebuild everything manually before publishing to npm. |
|
@williamngan, I've reverted the commits. You better squash this when you merge, or if you prefer that I rebase, let me know. I'm leaving the |
|
Great to have this event passed into callback from advanced functionality. Thanks @tibotiber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @williamngan,
These suggested changes pass the
MouseEventthrough UIs so we can differentiate between left and right clicks (among others I guess). I left theevtat the end and tested that it is backward compatible. The new API signature is:As you can see
onClicknow provides the MouseEvent as well which means we can test a bunch of stuff, e.g. differentiate left and right clicks.Taking any feedback you may have.