Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromHex fix #4

Merged
merged 2 commits into from
Nov 3, 2017
Merged

fromHex fix #4

merged 2 commits into from
Nov 3, 2017

Conversation

kijowski
Copy link
Contributor

@kijowski kijowski commented Nov 2, 2017 •
edited
Loading

Hi,
First of all - thanks for creating this interesting library!
While playing around with it I've found a problem with fromHex function that should be fixed with this PR.

@kijowski kijowski changed the title From hex fix fromHex fix Nov 2, 2017
@williamngan
Copy link
Owner

Hi Michal, thanks so much for the bug fix and the test cases!

I'll take a look at your other PR soon too. Thanks again :)

@williamngan williamngan merged commit baba0f2 into williamngan:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kijowski @williamngan