Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18562] re-evaluated test exclusions for ts.preview and ts.boota… #17330

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

istudens
Copy link
Contributor

…ble.preview profiles

Issue: https://issues.redhat.com/browse/WFLY-18562

@istudens istudens marked this pull request as draft October 20, 2023 09:13
@istudens
Copy link
Contributor Author

I need to test this on CI. Locally it fails on ModelControllerMBeanTestCase due to java.lang.IllegalArgumentException: Default value not supported for ArrayType and TabularType exception on "jboss.as:management-root=server" -> getOperation("addSubsystemMicrometer") -> getParameterInfo("exposedSubsystems") and I need to consult this with Kabir as I can't understand why it fails.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Oct 20, 2023
@bstansberry
Copy link
Contributor

@istudens If that's the last thing blocking this (I saw some other CI failures but didn't investigate, nor have I done a code review), I suggest filing a WFLY against the Micrometer subsystem, and disabling the test with ts.preview with a comment noting the JIRA.

I suspect this actually has nothing to do with Preview, except that we include Micrometer in the default config there, so this test picks up issues there. We support Micrometer in standard WF though, it's just not in the default config.

I suspect this isn't a Micrometer bug per se, it's just it has an unusual thing, where an attribute of ModelType.LIST has a default value. That's a valid thing but it sounds like JMX might not like that.

@istudens
Copy link
Contributor Author

This needs https://issues.redhat.com/browse/WFCORE-6604 to fix the JMX issue.

@bstansberry
Copy link
Contributor

/retest

@bstansberry
Copy link
Contributor

@istudens The WFCORE-6604 fix is integrated into full WF now.

@istudens istudens force-pushed the WFLY-18562 branch 2 times, most recently from e3037b2 to db49746 Compare December 1, 2023 10:27
@istudens istudens marked this pull request as ready for review December 4, 2023 21:32
@bstansberry bstansberry merged commit 97a0c0e into wildfly:main Jan 19, 2024
15 checks passed
@bstansberry
Copy link
Contributor

Thanks @istudens!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants