[New Template] state/documentdb - DocumentDB cluster #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaswittig
approved these changes
Jun 16, 2020
state/documentdb.yaml
Outdated
| Type: 'AWS::DocDB::DBCluster' | ||
| Properties: | ||
| AvailabilityZones: | ||
| - {'Fn::ImportValue': !Sub '${ParentVPCStack}-AZA'} |
There was a problem hiding this comment.
What's the impact of deploying to two AZs only?
There was a problem hiding this comment.
I improved the template to use all available AZs
| MinValue: 1 | ||
| MaxValue: 35 | ||
| Default: 30 | ||
| DBClusterParameterGroupName: |
There was a problem hiding this comment.
What about adding a AWS::DocDB::DBClusterParameterGroup resource as well? Might be interesting to be able to modify the change_stream_log_retention_duration, for example. (see https://docs.aws.amazon.com/documentdb/latest/developerguide/cluster_parameter_groups-list_of_parameters.html)
| KmsKeyId: !If [HasParentKmsKeyStack, {'Fn::ImportValue': !Sub '${ParentKmsKeyStack}-KeyId'}, !Ref 'AWS::NoValue'] | ||
| MasterUsername: !Ref MasterUsername | ||
| MasterUserPassword: !Ref MasterUserPassword | ||
| Port: 27017 |
state/documentdb.yaml
Outdated
| DBSubnetGroupName: !Ref DBSubnetGroup | ||
| EnableCloudwatchLogsExports: | ||
| - audit | ||
| EngineVersion: '3.6.0' |
There was a problem hiding this comment.
future version will change having a parameter with 3.6.0 as default
grizzly-monkey
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.