use importlib for compatibility with python 3.12 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Tristan, That is odd, I've just looked through the history and cannot find where the regression occurred. I know I merged the previous PR & it says so. Anyway, I'll merge this and get a patch release out shortly after all the tests complete. Thanks again for finding this and submitting the fix (again!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Scott,
it seems the newest release has undone the changes I made in #192. Since you also dropped support for Python 3.8, I removed the try except clause since there is no more fallback needed. I'm unsure why I can't find the changes in the history of the file anymore, but here we go again :)
Best,
Tristan