Add automatic FCS file reading from FlowJo WSP files #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s automatically by URI.
Signed-off-by: Hersh Bhargava <hershkbhargava@gmail.com>
Signed-off-by: Hersh Bhargava <hershkbhargava@gmail.com>
Signed-off-by: Hersh Bhargava <hershkbhargava@gmail.com>
Signed-off-by: Hersh Bhargava <hershkbhargava@gmail.com>
Signed-off-by: Hersh Bhargava <hershkbhargava@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing my fix to #166. Modified Workspace constructor and _parse_wsp_samples to read the URI from the WSP file, if present, and use those FCS files.
run_tests.py did not work for me even before making modifications, please advise on that if critical.