Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parametrized optional FCS keywords #18

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

zbjornson
Copy link
Contributor

Adds support for setting $Pn[DFLOPTV] and $PnCALIBRATION. Skips the deprecated keywords ($Gn*, $PKn, $PKNn) and the rarely used ones ($RnI, $RnW, $CSVnFLAG).

FlowKit test run: https://github.com/primitybio/FlowIO/actions/runs/3130423878


Last PR for now. There are a few other changes I'd consider, but none are pressing:

  • Don't upper-case all keys. Some importers are erroneously case-sensitive, so this can break those. Mixed case can also be easier to read as a human (things like P2DetectorName).
  • Use a different delimiter than / since that's also found in file paths and the source of many invalid FCS files.
  • Allow zero-length files. They're valid and sometimes useful.

Adds support for setting `$Pn[DFLOPTV]` and `$PnCALIBRATION`. Skips the deprecated keywords (`$Gn*`, `$PKn`, `$PKNn`) and the rarely used ones (`$RnI`, `$RnW`, `$CSVnFLAG`).
@whitews
Copy link
Owner

whitews commented Sep 26, 2022

Thanks Zach, your contributions are very much appreciated! I'll try to get to all of these this week.

@zbjornson zbjornson changed the base branch from master to develop January 17, 2023 20:26
@whitews whitews merged commit 6d729b7 into whitews:develop Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants