Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set document.currentScript for <script type="module"> #997

Closed
domenic opened this issue Apr 5, 2016 · 4 comments
Closed

Don't set document.currentScript for <script type="module"> #997

domenic opened this issue Apr 5, 2016 · 4 comments
Labels
normative change

Comments

@domenic
Copy link
Member

domenic commented Apr 5, 2016

Per discussions in web components F2F, we don't like this API anymore and want to consider a better one for new stuff like modules and scripts-inside-shadow-DOM.

/cc @jonco3 @ajklein @Constellation @DigiTec
@domenic domenic mentioned this issue Apr 5, 2016
Closed
@smaug----
Copy link

How should the relevant events work in this case. For shadow DOM we can mark the events scoped, but that doesn't really affect to the behavior in light DOM.

@domenic
Copy link
Member Author

domenic commented Apr 5, 2016

beforescriptexecute and afterscriptexecute, you mean? They seem somewhat unrelated to me... modules would still have them.

@smaug----
Copy link

Don't know why those are unrelated, but anyhow, something to keep in mind at least.

@domenic domenic mentioned this issue Apr 5, 2016
Merged
domenic added a commit that referenced this issue Apr 5, 2016
@domenic
Don't update document.currentScript for module scripts
ff9cf1d 
Closes #997.
@annevk
Copy link
Member

annevk commented Apr 6, 2016

@domenic I think we should not dispatch those either. I think the idea with those events is that you can then grab the script (using document.currentScript and manipulate it before it gets executed. The events are also controversial per #943 so only Gecko would implement support for them presumably...

domenic added a commit that referenced this issue Apr 11, 2016
@domenic
Make module scripts modify less global script state
33ea3ae 
They no longer set document.currentScript, or fire beforescriptexecute
and afterscriptexecute events.

Closes #997. See #1013 for a future alternative to
document.currentScript, and #943 for more discussion of the events.
domenic added a commit that referenced this issue Apr 13, 2016
@domenic
Make module scripts modify less global script state
456c115 
They set document.currentScript to null, and no longer fire
beforescriptexecute and afterscriptexecute events.

Closes #997. See #1013 for a future alternative to
document.currentScript, and #943 for more discussion of the events.
domenic added a commit that referenced this issue Apr 14, 2016
@domenic
Make module scripts modify less global script state
177d30d 
They set document.currentScript to null, and no longer fire
beforescriptexecute and afterscriptexecute events.

Closes #997. See #1013 for a future alternative to
document.currentScript, and #943 for more discussion of the events.
annevk pushed a commit that referenced this issue Apr 15, 2016
@domenic @annevk
Don't update document.currentScript for module scripts
6918282 
Make module scripts modify less global script state. They set document.currentScript to null, and no longer fire beforescriptexecute and afterscriptexecute events.

Closes #997. See #1013 for a future alternative to document.currentScript, and #943 for more discussion of the events.
@laukstein laukstein mentioned this issue Jun 12, 2019
Closed
@Conduitry Conduitry mentioned this issue Aug 16, 2021
Closed
This was referenced Jan 4, 2022
Merged
Merged
This was referenced Feb 11, 2022
Merged
Merged
Merged
This was referenced Feb 22, 2022
Merged
Merged
@github-actions github-actions bot mentioned this issue Mar 10, 2022
Merged
19 tasks
@github-actions github-actions bot mentioned this issue Apr 25, 2022
Merged
3 tasks
@github-actions github-actions bot mentioned this issue Jun 22, 2022
Merged
3 tasks
This was referenced Jul 8, 2022
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this issue Jul 25, 2022
Merged
This was referenced Aug 18, 2022
Merged
Merged
Merged
@github-actions github-actions bot mentioned this issue Aug 28, 2022
Merged
This was referenced Sep 18, 2022
Merged
Merged
This was referenced Oct 17, 2022
Closed
Merged
@github-actions github-actions bot mentioned this issue Nov 23, 2022
Merged
This was referenced Dec 10, 2022
Merged
Merged
This was referenced Feb 19, 2023
Merged
Merged
@github-actions github-actions bot mentioned this issue Jun 10, 2023
Merged
This was referenced Aug 2, 2023
Merged
Merged
@github-actions github-actions bot mentioned this issue May 9, 2024
Merged
@quinn quinn mentioned this issue Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
normative change
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @annevk @smaug----