Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Portuguese baseline and Portuguese (Portugal) #106

Closed
wants to merge 1 commit into from
Closed

Adding Portuguese baseline and Portuguese (Portugal) #106

wants to merge 1 commit into from

Conversation

ner00
Copy link
Contributor

@ner00 ner00 commented Nov 19, 2021

The baseline is added to serve other Portuguese-speaking users not immediately covered by the Brazilian or European variants, like Angola or Mozambique.

I just now noticed the Transifex project, do you want me to cancel this PR and go through Transifex? I'm fairly familiar with its, but since this seems to be the first implementation of this particular language maybe you can pull directly?

Thanks for the awesome work!

The baseline is added to serve other Portuguese-speaking users not immediately covered by the Brazilian or European variants, like Angola or Mozambique.
@prsnbrg
Copy link
Contributor

prsnbrg commented Nov 27, 2021

Hi!
Please add the translations in values-* via Transifex.

Everything else looks good to me.

@ner00
Copy link
Contributor Author

ner00 commented Nov 27, 2021

I have requested but haven't been accepted to the translation team so far.

Since the language/s is in a blank state the project manager over at Transifex could as well just import the files, but if not I'll gladly go over the painstaking task of adding them manually, all I really need it to have translation access to the languages involved.

@ner00
Copy link
Contributor Author

ner00 commented Dec 8, 2021

Now in Transifex project page: https://www.transifex.com/a-302/qr-barcode-scanner/

@ner00 ner00 closed this Dec 8, 2021
@ner00 ner00 deleted the develop branch December 8, 2021 13:20
@prsnbrg
Copy link
Contributor

prsnbrg commented Dec 8, 2021

You can add the changes and additions in /fastlane/metadata/android/ to the repo via a pull request.

@ner00
Copy link
Contributor Author

ner00 commented May 28, 2022

Hi! Please add the translations in values-* via Transifex.

This turned out to be terrible advice, given that the translation work from Transifex was completely ignored, and in fact, only those pushed through here were actually ever pulled and merged into the actual release.

I've pushed https://github.com/wewewe718/QrAndBarcodeScanner/pull/128/files to reflect this inconsistency in the README since it is also inaccurate as to the mechanics of merging new translations, or updates to existing ones for that matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants