Docker improvements #283
Merged
Docker improvements #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suggested by hadolint
suggested by hadolint
mkdir -p -m 700 only creates the last directory with the 700 permission not the ones created by the -p switch in lower levels. Also some of the directories already exist and do not need to be created.
Codecov Report
@@ Coverage Diff @@
## 5.x #283 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 1719 1719
=========================================
Hits 1719 1719 Continue to review full report at Codecov.
|
kleisauke
reviewed
May 30, 2021
| @@ -13,3 +13,4 @@ | |||
| .editorconfig | |||
| .git* | |||
| *.md | |||
| docker/ | |||
There was a problem hiding this comment.
Oh curious, wasn't this covered by the "Ignore all subdirectories"-statement (*/*) above? I'll have a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.