Skip to content

Improve Docker image & deployment #180

Closed
@kleisauke

Description

Things that should be done, in no order:

  • Create an organization on Docker Hub.
    Done: https://hub.docker.com/u/weserv.
  • Copy the contents of this repository to the container instead of defining /var/www/imagesweserv as volume.
    • Perhaps we could just clone the repo (?). For example:
    RUN git clone https://github.com/weserv/images.git /var/www/imagesweserv
    
  • Copy /config/nginx/conf.d to /usr/local/openresty/nginx/conf/conf.d/ instead of defining that directory as volume.
  • Add RUN make dev to the Dockerfile to install the required LuaRocks dependencies.
  • Remove the heavy-weight supervisord approach and set the Docker entrypoint to:
    ENTRYPOINT ["nginx", "-g", "daemon off;"]
    
    • This implies that Redis rate limiter is disabled in the Docker file. Is this the right solution?
  • Should we remove /dev/shm as a volume?
  • Publish the revamped Docker image to GitHub's Container Registry.
  • Test the image on the Google Cloud Platform. See: Deploying the Docker image on Google Cloud Platform #179.

If someone knows more tasks, please feel free to add them in the comments.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions