Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add devcontainer #37

Closed
Nova38 opened this issue Oct 24, 2022 · 3 comments
Closed

Add devcontainer #37

Nova38 opened this issue Oct 24, 2022 · 3 comments
Assignees
@Nova38
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Nova38
Copy link
Contributor

Nova38 commented Oct 24, 2022

Devcontainer's allow for a consistent development environment isolated from the base system. They are useful for helping to isolate bugs that could be due to a misconfiguration on a developer's device from bugs that arise from the core project. I will make a pull request for this issue where I will have it setup the poetry environment.
@wenkokke wenkokke added help wanted Extra attention is needed good first issue Good for newcomers enhancement New feature or request labels Mar 21, 2023
Nova38 added a commit to Nova38/talondoc that referenced this issue Apr 16, 2023
@Nova38
Add devcontainer
5a7b8f6 
Fixes wenkokke#37
@Nova38 Nova38 mentioned this issue Apr 16, 2023
Closed
Nova38 added a commit to Nova38/talondoc that referenced this issue Apr 16, 2023
@Nova38
Add devcontainer (added initing the submodule)
1b09ec6 
Fixes wenkokke#37
Nova38 added a commit to Nova38/talondoc that referenced this issue Apr 16, 2023
@Nova38
Add devcontainer
be1a0a5 
Fixes wenkokke#37
@Nova38
Copy link
Contributor Author

Nova38 commented Apr 22, 2023

The devcontainer currently only has python3.10 installed. It doesn't look like there is an inbuilt feature for installing multiple system pythons in the devcontainer features. Should we use pyenv to install 3.9 and 3.11 for the tests?

@wenkokke
Copy link
Owner

Yes, and 3.9 should probably be the default.

wenkokke pushed a commit that referenced this issue May 7, 2023
@Nova38 @wenkokke
Add devcontainer
95b97ab 
Fixes #37
wenkokke pushed a commit that referenced this issue May 7, 2023
@Nova38 @wenkokke
Add devcontainer (added initing the submodule)
885895c 
Fixes #37
wenkokke pushed a commit that referenced this issue May 7, 2023
@Nova38 @wenkokke
Add devcontainer
9196efa 
Fixes #37
@wenkokke
Copy link
Owner

Fixed by #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nova38 Nova38

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add devcontainer Nova38/talondoc
2 participants
@wenkokke @Nova38