Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Feature: complete the original author's webhook functions and add two-way webhook type #2665

Merged
merged 5 commits into from
Sep 4, 2019
Merged

Add Feature: complete the original author's webhook functions and add two-way webhook type #2665

merged 5 commits into from
Sep 4, 2019

Conversation

whowillcare
Copy link
Contributor

@whowillcare whowillcare commented Aug 30, 2019 •
edited by mquandalle
Loading

  1. Make webhook function more complete by allowing user to specify name and token of a webhook to increase security
  2. Allow wekan admin to sepcify a global webhook
  3. Add new type of two-way webhook that can act on the JSON webhook return payload:
    if the payload data contains cardId, boardId, and comment key words,
    i. if it has commentId, an existing comment will be modified
    ii. if it doesn't have commentId, then a new comment will be added
    otherwise, does nothing

This change is Reviewable

@xet7 xet7 merged commit bfbe32e into wekan:master Sep 4, 2019
@xet7 xet7 mentioned this pull request Nov 4, 2019
Closed
@xet7 xet7 mentioned this pull request Jan 28, 2020
Closed
@xet7 xet7 mentioned this pull request Mar 19, 2020
Closed
@xet7 xet7 mentioned this pull request Oct 11, 2020
Open
@xet7 xet7 mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whowillcare @xet7