Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'npm run build' before 'npm start' in README.md #361

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Adds 'npm run build' before 'npm start' in README.md #361

merged 1 commit into from
Jul 5, 2022

Conversation

zackees
Copy link
Contributor

@zackees zackees commented Jul 5, 2022

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

The readme omitted the required step of npm run build before starting the server.

Which issue (if any) does this pull request address?

It fixes the issue so that users can more easily self host the application.

Is there anything you'd like reviewers to focus on?

No, this should be straight forward.

@welcome
Copy link

welcome bot commented Jul 5, 2022

🙌 Thanks for opening this pull request! You're awesome.

@alxhotel alxhotel merged commit 00e14d7 into webtorrent:master Jul 5, 2022
@welcome
Copy link

welcome bot commented Jul 5, 2022

🎉 Congrats on getting your first pull request landed!

@zackees zackees deleted the zackees-fix-readme-npm-build branch July 6, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants