Skip to content
This repository has been archived by the owner on Sep 17, 2020. It is now read-only.

Player doesn't support links which go to images? #60

Closed
vitorio opened this issue May 25, 2018 · 2 comments
Closed

Player doesn't support links which go to images? #60

vitorio opened this issue May 25, 2018 · 2 comments

Comments

@vitorio
Copy link

vitorio commented May 25, 2018

Hello, I'm archiving a social media site, and some of the links on the site go directly to image files (e.g. binary data served as image/jpeg).

While Webrecorder.io captures the JPEG file, and will display it online, Webrecorder Player doesn't seem to. Clicking the link doesn't do anything. The JPEG file is in the WARC, I can manually visit it in the online Webrecorder.io site. But I can't paste the captured JPEG URL into Webrecorder Player, it doesn't appear in the bookmark list (since it's not an HTML page), and there appears to be no way to view it.

Is this the expected behavior? That non-HTML pages are not bookmarks and also not able to be viewed when clicked on as links?
@ikreymer
Copy link
Member

This may be partially fixed as there was an issue where links that opened in a new tab did not work at all in the player. They should now open in the same tab. In case the JPEG links were opening in a new tab, this may work now in 1.6.0

We are working on a more general way to access non-bookmark resources in the WARC and to add them as bookmarks in Webrecorder itself. This will eventually be available in webrecorder.io

@ikreymer ikreymer mentioned this issue Nov 1, 2018
Merged
ikreymer added a commit that referenced this issue Nov 1, 2018
@ikreymer
MiscFixes for 1.6.1 Release (#72)
69e370b 
- Fix entering urls directly into location bar (addresses #60)
- Fix Open... text formatting #56
- Add tab focus for nav buttons #49
- Add devtools for webview under View -> Toggle Page Developer Tools #59
- Bump to latest pywb build
@ikreymer
Copy link
Member

ikreymer commented Nov 1, 2018

Additionally, you can also enter any url directly into the location bar and it will be loaded in the player. (There was a bug in 1.6.0 but should work in 1.6.1)

Closing this for now as this should address most of the issues.

@ikreymer ikreymer closed this as completed Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitorio @ikreymer