Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Redis pending state serialization to store as object #209

Closed
tw4l opened this issue Jan 23, 2023 · 0 comments · Fixed by #212
Closed

Modify Redis pending state serialization to store as object #209

tw4l opened this issue Jan 23, 2023 · 0 comments · Fixed by #212
Assignees

Comments

@tw4l
Copy link
Member

tw4l commented Jan 23, 2023

Pending state is stored as a flat url->JSON string when in Redis, but as a JSON object in local memory state. For consistency in logging, we want to log both as JSON objects rather than strings, which will require a change to the RedisCrawlState serialization format.

@tw4l tw4l self-assigned this Jan 23, 2023
@tw4l tw4l moved this from Todo to Dev In Progress in Webrecorder Projects Jan 23, 2023
@tw4l tw4l moved this from Dev In Progress to PR In Review in Webrecorder Projects Jan 23, 2023
@github-project-automation github-project-automation bot moved this from PR In Review to Done! in Webrecorder Projects Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant