Allow self for globalObject in async chunks #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
valscion
reviewed
Oct 16, 2019
| @@ -0,0 +1 @@ | |||
| (self.webpackJsonp=self.webpackJsonp||[]).push([[27],{1:function(e,n,t){console.log("Chuck Norris")}}]); | |||
Update changelog
|
Thanks! |
|
Released in v3.6.0 |
|
❤️ Thanks so much for the quick review/ release! |
|
Thanks for the contribution 😊. Happened to have a nice slot to review this PR today right as GitHub notification popped up 😄 |
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
selfas theglobalObjectwhen searching for async chunks. We useselffor our client bundles because it supports both browsers and web workers, and we have some libraries that will create workers as child compilations of the client compile. Technically you can pass a lot more in here (as shown in #288, although more complex configuration like that is still not supported with my change), but this PR just adds auto-detection ofself. Given that it is technically the default value, this seems like an appropriate inclusion to me.