Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: localsLoader #816

Merged
merged 1 commit into from
Nov 27, 2018
Merged

test: localsLoader #816

merged 1 commit into from
Nov 27, 2018

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Migrate on snapshot testing

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #816 into master will decrease coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
- Coverage   99.16%   98.05%   -1.12%     
==========================================
  Files           9        9              
  Lines         360      360              
  Branches       85       85              
==========================================
- Hits          357      353       -4     
- Misses          3        6       +3     
- Partials        0        1       +1
Impacted Files Coverage Δ
lib/utils.js 90.16% <0%> (-6.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b190e51...42db1d7. Read the comment docs.

@alexander-akait
Copy link
Member Author

Coverage is lower because we have checks for webpack@2 and webpack@3 loader context, will be removed in other PRs

@alexander-akait alexander-akait merged commit e081b42 into master Nov 27, 2018
@alexander-akait alexander-akait deleted the test-locals-loader branch November 27, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant