fix(loader): trim unquoted import urls #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I don't think the appveyor failure has anything to do with this PR |
|
@joelgallant Just for note, already fixed in |
|
This would still apply to the stable version though yeah? |
joelgallant
force-pushed
the
fix-whitespace-import
branch
from
a57f8ab to
b619d0d
Compare
|
@joelgallant yep |
alexander-akait
approved these changes
Oct 10, 2018
michael-ciniawsky
changed the title
michael-ciniawsky
approved these changes
Oct 10, 2018
This was referenced Oct 29, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #781
Did you add tests for your changes?
Yep
If relevant, did you update the README?
Nope
Summary
This removes trailing whitespace from unquoted import urls
Does this PR introduce a breaking change?
It shouldn't