Only thing maybe breaking is 'text/html' no longer has the charset. I assume because it could be multiple different values. It is usually set with the meta tag <meta charset="utf8">.

I could special case text/html to add it so this isn't potentially breaking.

@gpoitch feel free to send

Codecov Report

Merging #351 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   96.82%   96.86%   +0.03%     
==========================================
  Files           7        7              
  Lines         252      255       +3     
==========================================
+ Hits          244      247       +3     
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cfe7c...7eaeb9e. Read the comment docs.

Codecov Report

Merging #351 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   96.77%   96.78%   +0.01%     
==========================================
  Files          12       12              
  Lines         279      280       +1     
  Branches       81       81              
==========================================
+ Hits          270      271       +1     
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2e32b...ab3f043. Read the comment docs.

/cc @gpoitch can you rebase PR? I think we are ready to merge and release this

@evilebottnawi good to go

@gpoitch A am little afraid about breaking change, maybe we can merge this and release after holidays? For fast fixing/reverting if problem will be for many developers?

@evilebottnawi There is a special condition to avoid the breaking change.

As an alternative, we could maintain our own blacklist (.wasm, .usdz so far) instead of using mime-db. That would leave everything else as-is.

@gpoitch i think your solution is right, but i think we really can break some app, better release this as major, maybe we can add temporary workaround (example new option)

Hmm been thinking about it. I think maybe just blacklisting usdz like wasm is on master would be much less disruptive. If anymore types come up we could reconsider this.

@evilebottnawi Here's a simpler/safer alternative PR: #357

Close in favor #357