fix: all tests cases

webpack · Sep 20, 2024 · 14d8fa8 · 14d8fa8
1 parent 96fe32b
commit 14d8fa8
Show file tree

Hide file tree

Showing 13 changed files with 39 additions and 52 deletions.
diff --git a/test/configCases/output-module/iife-entry-module-with-others/index.js b/test/configCases/output-module/iife-entry-module-with-others/index.js
@@ -1,20 +1,16 @@
-import { value as v1 } from "./module1";
-const v2 = require("./module2")
-const module3Inc = require("./module3")
+import { value as value1 } from './module1'
+const value2 = require('./module2')
+const value3 = require('./module3')
 
-const index_value = 10;
-let value = 42;
+let value = 42
+let src_value = 43
+let src_src_value = 44
 
-function inc() {
-	value++;
-}
-
-it("single inlined module should not be wrapped in IIFE", () => {
-	expect(value).toBe(42);
-	expect(v1).toBe(undefined);
-	expect(v2).toBe(undefined);
-	expect(module3Inc).toBe(undefined);
-	inc();
-	expect(value).toBe(43);
-	expect(index_value).toBe(10);
-});
+it('inlined module should not leak to non-inlined modules', () => {
+  expect(value1).toBe(undefined)
+  expect(value).toBe(42)
+  expect(src_value).toBe(43)
+  expect(src_src_value).toBe(44)
+  expect(value2).toBe("undefined") // should not touch leaked `value` variable
+  expect(value3).toBe("undefined") // should not touch leaked `src_value` variable
+})
diff --git a/test/configCases/output-module/iife-entry-module-with-others/module1.js b/test/configCases/output-module/iife-entry-module-with-others/module1.js
@@ -1,3 +1,3 @@
-let value;
+let value
 
-export { value };
+export { value }
diff --git a/test/configCases/output-module/iife-entry-module-with-others/module2.js b/test/configCases/output-module/iife-entry-module-with-others/module2.js
@@ -1,3 +1 @@
-let value
-
-module.exports = value
+module.exports = typeof value
diff --git a/test/configCases/output-module/iife-entry-module-with-others/module3.js b/test/configCases/output-module/iife-entry-module-with-others/module3.js
@@ -1,3 +1 @@
-let inc
-
-module.exports = inc
+module.exports = typeof src_value
diff --git a/test/configCases/output-module/iife-innter-strict/foo.cjs b/test/configCases/output-module/iife-innter-strict/foo.cjs
@@ -1 +1 @@
-module.exports = 'foo'
+module.exports = 42;
diff --git a/test/configCases/output-module/iife-innter-strict/index.mjs b/test/configCases/output-module/iife-innter-strict/index.mjs
@@ -1 +1,14 @@
-import foo from './foo.cjs'
+import foo from  './foo.cjs';
+
+let answer
+
+try {
+    delete Object.prototype; // will throw error in strict mode
+		answer = 'no';
+	} catch {
+		answer = 'yes';
+}
+
+it("multiple inlined modules should be wrapped in IIFE to isolate from other inlined modules and chunk modules", () => {
+	expect(answer).toBe("yes"); // the code should throw in strict mode
+});
diff --git a/test/configCases/output-module/iife-multiple-entry-modules/index-1.js b/test/configCases/output-module/iife-multiple-entry-modules/index-1.js
diff --git a/test/configCases/output-module/iife-multiple-entry-modules/index-2.js b/test/configCases/output-module/iife-multiple-entry-modules/index-2.js
diff --git a/test/configCases/output-module/iife-multiple-entry-modules/index1.js b/test/configCases/output-module/iife-multiple-entry-modules/index1.js
@@ -0,0 +1,4 @@
+
+ it("multiple inlined modules should be wrapped in IIFE to isolate from other inlined modules and chunk modules", () => {
+	expect(typeof value).toBe("undefined"); // `value` in index2 should not leak to index1
+});
diff --git a/test/configCases/output-module/iife-multiple-entry-modules/index2.js b/test/configCases/output-module/iife-multiple-entry-modules/index2.js
@@ -0,0 +1 @@
+var value = 42
diff --git a/test/configCases/output-module/iife-multiple-entry-modules/module1.js b/test/configCases/output-module/iife-multiple-entry-modules/module1.js
diff --git a/test/configCases/output-module/iife-multiple-entry-modules/module2.js b/test/configCases/output-module/iife-multiple-entry-modules/module2.js
diff --git a/test/configCases/output-module/iife-multiple-entry-modules/webpack.config.js b/test/configCases/output-module/iife-multiple-entry-modules/webpack.config.js
@@ -1,7 +1,7 @@
 /** @type {import("../../../../").Configuration[]} */
 module.exports = [
 	{
-		entry: ["./index-1.js", "./index-2.js"],
+		entry: ["./index1.js", "./index2.js"],
 		output: {
 			module: true
 		},