fix: correct plugin order for CSS Modules #534

OliverJAsh · 2017-05-16T13:44:32Z

Fixes #533

jsf-clabot · 2017-05-16T13:44:34Z

All committers have signed the CLA.

alexander-akait · 2017-05-16T14:34:40Z

@OliverJAsh We are preparing for release css-loader v1, new version don't support css-modules. If your want to work with css-modules best use postcss-loader with postcss-modules(https://github.com/css-modules/postcss-modules). Also your can help our with webpack-contrib/postcss-loader#227.

Now we accept only critical bug fixes for css-loader.

alexander-akait · 2017-05-16T14:35:50Z

@OliverJAsh new version of loader will be support only icss spec (https://github.com/css-modules/icss)

michael-ciniawsky · 2017-05-22T08:58:44Z

@OliverJAsh Did you test this change with a larger code base for breaking changes, it eventually isn't breaking and could go as a semver minor

OliverJAsh · 2017-05-22T13:18:09Z

I have only tested against one large code base. Others may like to try it out

michael-ciniawsky

CSS Modules Maintainer gave me a rubberstamp 👍 on this, since postcss-modules-values is basically independent (but should be the first). This PR would change the plugin order to align with css-modules-require-hook/css-modules-loader-core and is recommended. Still the risk that whatever current bloatbase might be out there could possibly break 😛

michael-ciniawsky · 2017-05-23T06:12:07Z

These may need a short handwritten note in the release notes, to be aware of edge cases otherwise I respond to eventual issues :)

michael-ciniawsky · 2017-05-23T06:12:26Z

@OliverJAsh Thx

OliverJAsh · 2017-05-23T08:27:37Z

Great, thanks! When will this be released, do you know?

joshwiens · 2017-05-25T20:38:12Z

Right about now - https://github.com/webpack-contrib/css-loader/blob/v0.28.3/CHANGELOG.md#0283-2017-05-25

This Pull Request updates dependency [css-loader](https://github.com/webpack-contrib/css-loader) from `^0.28.11` to `^1.0.0` <details> <summary>Release Notes</summary> ### [`v1.0.0`](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md#100httpsgithubcomwebpack-contribcss-loadercomparev02811v100-2018-07-06) [Compare Source](webpack-contrib/css-loader@v0.28.11...v1.0.0) ##### BREAKING CHANGES * remove `minimize` option, use [`postcss-loader`](https://github.com/postcss/postcss-loader) with [`cssnano`](https://github.com/cssnano/cssnano) or use [`optimize-cssnano-plugin`](https://github.com/intervolga/optimize-cssnano-plugin) plugin * remove `module` option, use `modules` option instead * remove `camelcase` option, use `camelCase` option instead * remove `root` option, use [`postcss-loader`](https://github.com/postcss/postcss-loader) with [`postcss-url`](https://github.com/postcss/postcss-url) plugin * remove `alias` option, use [`resolve.alias`](https://webpack.js.org/configuration/resolve/) feature or use [`postcss-loader`](https://github.com/postcss/postcss-loader) with [`postcss-url`](https://github.com/postcss/postcss-url) plugin * update `postcss` to `6` version * minimum require `nodejs` version is `6.9` * minimum require `webpack` version is `4` #### [0.28.11](webpack-contrib/css-loader@v0.28.10...v0.28.11) (2018-03-16) ##### Bug Fixes * **lib/processCss:** don't check `mode` for `url` handling (`options.modules`) ([#698](`https://github.com/webpack-contrib/css-loader/issues/698`)) ([c788450](webpack-contrib/css-loader@c788450)) #### [0.28.10](webpack-contrib/css-loader@v0.28.9...v0.28.10) (2018-02-22) ##### Bug Fixes * **getLocalIdent:** add `rootContext` support (`webpack >= v4.0.0`) ([#681](`https://github.com/webpack-contrib/css-loader/issues/681`)) ([9f876d2](webpack-contrib/css-loader@9f876d2)) #### [0.28.9](webpack-contrib/css-loader@v0.28.8...v0.28.9) (2018-01-17) ##### Bug Fixes * ignore invalid URLs (`url()`) ([#663](`https://github.com/webpack-contrib/css-loader/issues/663`)) ([d1d8221](webpack-contrib/css-loader@d1d8221)) #### [0.28.8](webpack-contrib/css-loader@v0.28.7...v0.28.8) (2018-01-05) ##### Bug Fixes * **loader:** correctly check if source map is `undefined` ([#641](`https://github.com/webpack-contrib/css-loader/issues/641`)) ([0dccfa9](webpack-contrib/css-loader@0dccfa9)) * proper URL escaping and wrapping (`url()`) ([#627](`https://github.com/webpack-contrib/css-loader/issues/627`)) ([8897d44](webpack-contrib/css-loader@8897d44)) #### [0.28.7](webpack-contrib/css-loader@v0.28.6...v0.28.7) (2017-08-30) ##### Bug Fixes * pass resolver to `localsLoader` (`options.alias`) ([#601](`https://github.com/webpack/css-loader/issues/601`)) ([8f1b57c](webpack-contrib/css-loader@8f1b57c)) #### [0.28.6](webpack-contrib/css-loader@v0.28.5...v0.28.6) (2017-08-30) ##### Bug Fixes * add support for aliases starting with `/` (`options.alias`) ([#597](`https://github.com/webpack/css-loader/issues/597`)) ([63567f2](webpack-contrib/css-loader@63567f2)) #### [0.28.5](webpack-contrib/css-loader@v0.28.4...v0.28.5) (2017-08-17) ##### Bug Fixes * match mutliple dashes (`options.camelCase`) ([#556](`https://github.com/webpack/css-loader/issues/556`)) ([1fee601](webpack-contrib/css-loader@1fee601)) * stricter `[@import]` tolerance ([#593](`https://github.com/webpack/css-loader/issues/593`)) ([2e4ec09](webpack-contrib/css-loader@2e4ec09)) #### [0.28.4](webpack-contrib/css-loader@v0.28.3...v0.28.4) (2017-05-30) ##### Bug Fixes * preserve leading underscore in class names ([#543](`https://github.com/webpack/css-loader/issues/543`)) ([f6673c8](webpack-contrib/css-loader@f6673c8)) #### [0.28.3](webpack-contrib/css-loader@v0.28.2...v0.28.3) (2017-05-25) ##### Bug Fixes * correct plugin order for CSS Modules ([#534](`https://github.com/webpack/css-loader/issues/534`)) ([b90f492](webpack-contrib/css-loader@b90f492)) #### [0.28.2](webpack-contrib/css-loader@v0.28.1...v0.28.2) (2017-05-22) ##### Bug Fixes * source maps path on `windows` ([#532](`https://github.com/webpack/css-loader/issues/532`)) ([c3d0d91](webpack-contrib/css-loader@c3d0d91)) #### [0.28.1](webpack-contrib/css-loader@v0.28.0...v0.28.1) (2017-05-02) ##### Bug Fixes * allow to specify a full hostname as a root URL ([#521](`https://github.com/webpack/css-loader/issues/521`)) ([06d27a1](webpack-contrib/css-loader@06d27a1)) * case insensitivity of [@import] ([#514](`https://github.com/webpack/css-loader/issues/514`)) ([de4356b](webpack-contrib/css-loader@de4356b)) * don't handle empty [@import] and url() ([#513](`https://github.com/webpack/css-loader/issues/513`)) ([868fc94](webpack-contrib/css-loader@868fc94)) * imported variables are replaced in exports if followed by a comma ([#504](`https://github.com/webpack/css-loader/issues/504`)) ([956bad7](webpack-contrib/css-loader@956bad7)) * loader now correctly handles `url` with space(s) ([#495](`https://github.com/webpack/css-loader/issues/495`)) ([534ea55](webpack-contrib/css-loader@534ea55)) * url with a trailing space is now handled correctly ([#494](`https://github.com/webpack/css-loader/issues/494`)) ([e1ec4f2](webpack-contrib/css-loader@e1ec4f2)) * use `btoa` instead `Buffer` ([#501](`https://github.com/webpack/css-loader/issues/501`)) ([fbb0714](webpack-contrib/css-loader@fbb0714)) ##### Performance Improvements * generate source maps only when explicitly set ([#478](`https://github.com/webpack/css-loader/issues/478`)) ([b8f5c8f](webpack-contrib/css-loader@b8f5c8f)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).

Fix CSS Modules plugin order

f52aea7

Fixes webpack-contrib#533

OliverJAsh mentioned this pull request May 16, 2017

README is misleading: cannot compose from value css-modules/postcss-icss-values#98

Closed

michael-ciniawsky changed the title ~~Fix CSS Modules plugin order~~ fix: CSS Modules plugin order May 22, 2017

michael-ciniawsky added priority: 4 (important) pr_action: Discuss semver: Minor severity: 2 (regression) type: Bug labels May 22, 2017

michael-ciniawsky self-assigned this May 22, 2017

michael-ciniawsky added this to the 0.29.0 milestone May 22, 2017

michael-ciniawsky requested review from bebraw, alexander-akait and joshwiens May 22, 2017 23:07

michael-ciniawsky approved these changes May 22, 2017

View reviewed changes

bebraw approved these changes May 23, 2017

View reviewed changes

michael-ciniawsky changed the title ~~fix: CSS Modules plugin order~~ fix: correct plugin order for CSS Modules May 23, 2017

michael-ciniawsky merged commit b90f492 into webpack-contrib:master May 23, 2017

This was referenced May 26, 2017

CssSyntaxError: postcss-modules-scope referenced class name "xyz" in composes not found #290

Closed

Color as classname fails #275

Closed

michael-ciniawsky modified the milestone: 0.29.0 May 27, 2017

snyk-bot mentioned this pull request Aug 16, 2019

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 DriveClutch/sellpy-dockerfiles#4

Closed

snyk-bot mentioned this pull request Jan 8, 2020

[Snyk] Upgrade css-loader from 0.17.0 to 0.28.11 timscharfenort/kibana#3

Open

This was referenced Jan 22, 2020

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 anyulled/Learn-Redux-Starter-Files#1

Open

[Snyk] Upgrade css-loader from 0.24.0 to 0.28.11 anyulled/react-skeleton#2

Closed

This was referenced Feb 23, 2020

[Snyk] Upgrade css-loader from 0.26.4 to 0.28.11 saurabharch/stitch-examples#2

Open

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 saurabharch/guesstimate-app#3

Open

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 saurabharch/CodeGenius#2

Open

snyk-bot mentioned this pull request Mar 7, 2020

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 yowainwright/react-workshop#4

Closed

This was referenced Apr 2, 2020

[Snyk] Upgrade css-loader from 0.26.4 to 0.28.11 fiverr/rollout_dashboard#48

Open

[Snyk] Upgrade css-loader from 0.19.0 to 0.28.11 rangle/react-day-picker#2

Open

snyk-bot mentioned this pull request Apr 24, 2020

[Snyk] Upgrade css-loader from 0.16.0 to 0.28.11 walmartlabs/bolt-standard-flux#3

Open

This was referenced May 4, 2020

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 Barnstorm-Online/votetracker#1

Open

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 React-Junkie/react-coffee-and-friends#2

Open

KrisPeachyKen mentioned this pull request Jul 30, 2024

[Snyk] Upgrade css-loader from 0.18.0 to 0.28.11 KrisPeachyKen/ai#2

Open

superadmiral mentioned this pull request Jul 30, 2024

[Snyk] Upgrade css-loader from 0.18.0 to 0.28.11 superadmiral/ai#2

Open

YinghanFeng mentioned this pull request Aug 2, 2024

[Snyk] Upgrade css-loader from 0.9.1 to 0.28.11 YinghanFeng/deco-ide#1

Open

go-benchmark1 mentioned this pull request Aug 16, 2024

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 go-benchmark1/pome#1

Open

Vishesh7797 mentioned this pull request Oct 26, 2024

[Snyk] Upgrade css-loader from 0.26.4 to 0.28.11 Vishesh7797/Sorting-Visualizer#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: correct plugin order for CSS Modules #534

fix: correct plugin order for CSS Modules #534

OliverJAsh commented May 16, 2017

jsf-clabot commented May 16, 2017 •

edited

Loading

alexander-akait commented May 16, 2017 •

edited

Loading

alexander-akait commented May 16, 2017 •

edited

Loading

michael-ciniawsky commented May 22, 2017

OliverJAsh commented May 22, 2017

michael-ciniawsky left a comment •

edited

Loading

michael-ciniawsky commented May 23, 2017

michael-ciniawsky commented May 23, 2017

OliverJAsh commented May 23, 2017

joshwiens commented May 25, 2017

fix: correct plugin order for CSS Modules #534

fix: correct plugin order for CSS Modules #534

Conversation

OliverJAsh commented May 16, 2017

jsf-clabot commented May 16, 2017 • edited Loading

alexander-akait commented May 16, 2017 • edited Loading

alexander-akait commented May 16, 2017 • edited Loading

michael-ciniawsky commented May 22, 2017

OliverJAsh commented May 22, 2017

michael-ciniawsky left a comment • edited Loading

Choose a reason for hiding this comment

michael-ciniawsky commented May 23, 2017

michael-ciniawsky commented May 23, 2017

OliverJAsh commented May 23, 2017

joshwiens commented May 25, 2017

jsf-clabot commented May 16, 2017 •

edited

Loading

alexander-akait commented May 16, 2017 •

edited

Loading

alexander-akait commented May 16, 2017 •

edited

Loading

michael-ciniawsky left a comment •

edited

Loading