New Admin UI - Link Component #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one is ready for review. The only thing I need to adjust is the [3px] ring size. Don't have a token for this, gonna get it probably next week since Kreso is absent tomo. |
leopuleo
reviewed
Dec 17, 2024
|
|
||
| const linkVariants = cva("font-sans rounded-xs", { | ||
| variants: { | ||
| size: { |
There was a problem hiding this comment.
I'm not sure we need a size variant: the font size of a link should be inherited from its parent; otherwise, we would end up in this situation:
<Text size="lg">Lorem ipsum with <Link size="lg">link</Link> text.</Text>
declaring the size prop twice.
leopuleo
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces the Link component.
Extra Changes
1. Default Text/Link Styles
I updated the
theme.scssfile and added default styles for all text and links that were not rendered via Text/Link components, respectively. I tested this manually then in Admin area.Previously, we had this:
2. Alert Links
Once I've added default styles for links, link in Alert boxes did not look as it's defined in Figma (links basically have the same styles as the text in the alert, except they're also bolded and underlined). So, I have to add a couple classes in there as well to preserve this.
3. Updated Tokens
I reimported tokens from Figma.
4. Colors With Alpha Were Still Imported
There were a couple color categories where ignoring colors with alpha/transparency was not added.
Those categories were:
fill,ringColor, andtextColor.How Has This Been Tested?
Manually.
Documentation
Changelog.