-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-trash-bin): add trash bin to app-headless-cms #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cypress E2E tests have been initiated (for more information, click here). ✨ |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
… leo/feat/admin-soft-delete
Pavel910
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Headless CMS now has basic trash bin functionalities. When an editor deletes an entry from the admin app, the entry will be moved to the trash bin instead of permanently deleted.
These are the available functionalities:
name
,deletedOn
andcreatedOn
fields.Permissions
Users with full access to the content model (
rwd
) can interact with the trash bin.Under the hood
Three new packages have been introduced:
app-trash-bin
: contains both the domains and the presentation for the trash bin. It exposes the mainTrashBin
component that will be used byapp-headless-cms
.app-trash-bin-common
: includes gateway abstractions and models used by multiple applications, such asapp-admin
. A separate package is required to avoid circular dependencies.app-utils
: contains some essential domains, applicable across multiple applications such as:Sorting
,Loading
andMeta
.Code organisation
While working on this feature, we are experimenting with the First Test Architecture and Clean Architecture.
Opening the
app-trash-bin
package you will see 2 folders:Domain
The folder contains relevant information at the domain level:
Presentation
The folder contains components useful to present data. Together with the components, we find:
How Has This Been Tested?
Jest - Manually