Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove @webiny/commodo and its typings #4057

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

Pavel910
Copy link
Collaborator

Changes

This PR removes the @webiny/commodo package which is no longer being used. WIth it, we can now also remove the types from the typings folder. We still use some @commodo packages directly, but this facade package was not used anywhere in our code base, so it is safe to be removed.

How Has This Been Tested?

Nothing to test here :)

@Pavel910 Pavel910 added this to the 5.40.0 milestone Mar 21, 2024
@Pavel910 Pavel910 self-assigned this Mar 21, 2024
@Pavel910 Pavel910 requested a review from adrians5j March 21, 2024 21:02
Copy link
Member

@adrians5j adrians5j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 😊

Just ran one failed test, just in case (flakyness probably).

@Pavel910 Pavel910 merged commit f8672b2 into next Mar 22, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants