Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ts-ignore directives #3724

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

brunozoric
Copy link
Contributor

@brunozoric brunozoric commented Nov 24, 2023

Changes

This PR replaces all possible ts-ignore directives with ts-expect-error.
Where ts-ignore was not removed, a comment was left to explain why is it there.

  • eslint will not allow @ts-ignore and @ts-nocheck without a comment next to them
  • @ts-expect-error is allowed without comments
  • @ts-check is not allowed at all

How Has This Been Tested?

Jest.

@brunozoric brunozoric added this to the 5.39.0 milestone Nov 24, 2023
@brunozoric brunozoric self-assigned this Nov 24, 2023
@brunozoric brunozoric marked this pull request as ready for review November 24, 2023 13:46
@brunozoric brunozoric changed the title refactor: remove ts-ignore directives refactor: repository cleanup Nov 24, 2023
@brunozoric brunozoric changed the title refactor: repository cleanup refactor: remove ts-ignore Nov 24, 2023
@brunozoric brunozoric changed the title refactor: remove ts-ignore refactor: remove ts-ignore directives Nov 24, 2023
@brunozoric brunozoric merged commit 2ae701f into next Nov 24, 2023
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant