feat: add bulk edit to File Manager #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavel910
requested changes
Nov 22, 2023
packages/api-file-manager/src/modelModifier/CmsModelModifier.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+48
to
+98
| const openWorkerDialog = (batch: BatchDTO) => { | ||
| showConfirmationDialog({ | ||
| title: "Edit files", | ||
| message: `You are about to edit ${filesLabel}. Are you sure you want to continue?`, | ||
| loadingLabel: `Processing ${filesLabel}`, | ||
| execute: async () => { | ||
| await worker.processInSeries(async ({ item, report }) => { | ||
| try { | ||
| const extensions = defaultFields.find( | ||
| field => field.fieldId === "extensions" | ||
| ); | ||
|
|
||
| const extensionsData = GraphQLInputMapper.toGraphQLExtensions( | ||
| item.extensions, | ||
| batch | ||
| ); | ||
|
|
||
| const output = omit(item, ["id", "createdBy", "createdOn", "src"]); | ||
|
|
||
| const fileData = { | ||
| ...output, | ||
| extensions: prepareFormData( | ||
| extensionsData, | ||
| extensions?.settings?.fields || [] | ||
| ) | ||
| }; | ||
|
|
||
| await updateFile(item.id, fileData); | ||
|
|
||
| report.success({ | ||
| title: `${item.name}`, | ||
| message: "File successfully edited." | ||
| }); | ||
| } catch (e) { | ||
| report.error({ | ||
| title: `${item.name}`, | ||
| message: e.message | ||
| }); | ||
| } | ||
| }); | ||
|
|
||
| worker.resetItems(); | ||
|
|
||
| showResultsDialog({ | ||
| results: worker.results, | ||
| title: "Edit files", | ||
| message: "Finished editing files! See full report below:" | ||
| }); | ||
| } | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Just a comment on this: I think it would be great to create a generic DialogPresenter class which can be reused across other presenter implementations, to manage thee dialog interactions. That way we'll be able to remove this huge bloat of coad from the components. Something to try.
Pavel910
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, we can bulk edit file custom registered fields.
To work, the field should be registered as
bulkEdit: trueas follows:By clicking on the action, the user will have the possibility to select the fields to edit and:
multipleValues)The file data is updated using the default bulk actions worker.
How Has This Been Tested?
Jest + Manually