Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Cloudfront Distributions - Ignore Changes In staging Property #4401

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

adrians5j
Copy link
Member

@adrians5j adrians5j commented Nov 20, 2024

Changes

With this PR, we are ignoring changes to the "staging" property when deploying Website app's Cloudfront distributions. I've added the following comment in the code:

We are ignoring changes to the "staging" property. This is because of the following.

With the 5.41.0 release of Webiny, we also upgraded Pulumi to v6. This introduced a change with how Cloudfront distributions are deployed, where Pulumi now also controls the new staging property.

If not set, Pulumi will default it to false. Which is fine, but, the problem is that, because this property did not exist before, it will always be considered as a change upon deployment.

We might think this is fine, but, the problem is that a change in this property causes a full replacement of the Cloudfront distribution, which is not acceptable. Especially if a custom domain has already been associated with the distribution. This then would require the user to disassociate the domain, wait for the distribution to be replaced, and then re-associate the domain. This is not a good experience.

How Has This Been Tested?

Manually. After adding staging to the ignoreChanges array, I was able to do any change to the property, and no replacements would be done by Pulumi.

Documentation

Changelog.

@webiny-bot webiny-bot added this to the 5.41.2 milestone Nov 20, 2024
@adrians5j adrians5j merged commit 4340e7f into dev Nov 20, 2024
16 checks passed
@adrians5j adrians5j deleted the adrian/cf-staging-ignore-changes branch January 7, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants