fix(app-headless-cms-common): push id in the list if no other field exists #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
approved these changes
Nov 11, 2024
leopuleo
pushed a commit
that referenced
this pull request
Nov 14, 2024
brunozoric
deleted the
bruno/fix/app-headless-cms-common/graphql-breaks-on-no-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When the user deletes all the fields except rich-text one, the UI generated a GraphQL query with
_emptyselector, which in turn broke the UI.The fix is simple: push
idfield in the field list when no other field exists.Additionally I found some fields getting queried more than once (check here), probably due to a bad merge, so I removed those.
How Has This Been Tested?
Manually.