Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-headless-cms): gracefully fall back to applicable fields #4203

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

Pavel910
Copy link
Collaborator

Changes

This PR removes throwing of errors when dealing with titleFieldId, descriptionFieldId, and imageFieldId in the CMS model editor. If an inapplicable field is sent to the API (which is not even possible through the UI, you can only do this via a programmatic API call), the API will no longer throw errors. Instead, it will gracefully fall back to the applicable fields, if possible. Otherwise, the field roles will simply be set to: id for titleFieldId, and null for descriptionFieldId and imageFieldId.

How Has This Been Tested?


@Pavel910 Pavel910 added this to the 5.40.3 milestone Jul 12, 2024
@Pavel910 Pavel910 self-assigned this Jul 12, 2024
@Pavel910 Pavel910 marked this pull request as ready for review July 22, 2024 16:47
@Pavel910 Pavel910 merged commit fb1a87e into dev Jul 23, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant