Allow clicking edit while paused and recently loved/unloved #4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inverse
approved these changes
Feb 23, 2024
|
Merging to get fix done immediately, but I agree, I wasn't sure what to name this. Do you have a different suggestion? Maybe persistentMode? |
|
I didn't have a better suggestion :/ the other one is more of the mode but can be in a transient state whereas the other is the actual mode right? |
|
Correct. Mode can be one of the three temporary modes (paused, loved, unloved), whereas the permanentMode is whatever the mode would be if there was no temporary override right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new field "permanentMode" to some communications, which ignores temporary modes paused, loved, unloved.
This allows some functionality in UI to be unaffected by temporary modes.
Closes #4539
It is worth noting this change is a little past trivial, but it's not huge.