Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDBIndex cursor iteration test #8119

Conversation

philipwalton
Copy link
Contributor

@philipwalton philipwalton commented Nov 8, 2017

Checks for the issue reported in this Safari bug:
https://bugs.webkit.org/show_bug.cgi?id=178995

Copy link
Contributor

@pwnall pwnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ nit, assuming Travis passes.

Thank you very much for the test!

cursor.continue();
} else {
assert_equals(cursorValues.length, 4,
`Expected cursor to iterate over 4 records`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The currently preferred style is "Cursor should iterate over 4 records"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ghost
Copy link

ghost commented Nov 8, 2017

Build PASSED

Started: 2017-11-09 00:16:22
Finished: 2017-11-09 00:21:34

Failing Jobs

  • safari:10.0

View more information about this build on:

@inexorabletash inexorabletash merged commit e9f7982 into web-platform-tests:master Nov 9, 2017
@philipwalton philipwalton deleted the idb-cursor-index-iteration branch November 9, 2017 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants