Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexed DB: remove assert_throws(null, ...) usage #5391

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 5, 2017

Helps with #5317.


This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

@ghost
Copy link

ghost commented Apr 5, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision af36594
Using browser at version BuildID 20170405115424; SourceStamp b043233ec04f06768d59dcdfb9e928142280f3cc
Starting 10 test iterations
All results were stable

All results

2 tests ran
/IndexedDB/idbdatabase_createObjectStore9-invalidparameters.htm
Subtest Results Messages
OK
createObjectStore: Invalid optionalParameters - autoInc and empty keyPath PASS
createObjectStore: Invalid optionalParameters - autoInc and keyPath array PASS
createObjectStore: Invalid optionalParameters - autoInc and keyPath array 2 PASS
createObjectStore: Invalid optionalParameters - autoInc and keyPath object PASS
/IndexedDB/idbobjectstore_deleted.htm
Subtest Results Messages
OK
Attempting to use deleted IDBObjectStore PASS

@ghost
Copy link

ghost commented Apr 5, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision af36594
Using browser at version 59.0.3053.3 dev
Starting 10 test iterations
All results were stable

All results

2 tests ran
/IndexedDB/idbdatabase_createObjectStore9-invalidparameters.htm
Subtest Results Messages
OK
createObjectStore: Invalid optionalParameters - autoInc and empty keyPath PASS
createObjectStore: Invalid optionalParameters - autoInc and keyPath array PASS
createObjectStore: Invalid optionalParameters - autoInc and keyPath array 2 PASS
createObjectStore: Invalid optionalParameters - autoInc and keyPath object PASS
/IndexedDB/idbobjectstore_deleted.htm
Subtest Results Messages
OK
Attempting to use deleted IDBObjectStore PASS

@inexorabletash
Copy link
Member

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@inexorabletash inexorabletash merged commit 1bcfa6e into master Apr 6, 2017
@annevk annevk deleted the annevk/idb-assert_throws branch April 6, 2017 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants