Add tests for get_title with multibyte characters #46584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AutomatedTester,
jgraham,
jrandolf-2,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
whimboo
approved these changes
Jun 3, 2024
webkit-commit-queue
pushed a commit
to haruhisa-shin/WebKit
that referenced
this pull request
Jun 6, 2024
…retrieved correctly https://bugs.webkit.org/show_bug.cgi?id=270063 Reviewed by Alexey Proskuryakov. If the document title contains multibyte characters such as Japanese or entity references, the "Get Title" result will be garbled. The title string is obtained by JavaScript's "document.title()", and this data is encoded in UTF8. However, the StringBuilder.append() function used to create HTTP messages uses fromLatin1() internally to generate strings from byte data. This seems to be causing the multibyte characters to be garbled. This patch changes to use String::fromUTF8() before concatenation to restore the correct WTF::String even if it contains multibyte characters. Also, the change of get.py is regression test for this issue. This is an export from web-platform-tests/wpt#46584. * Source/WebDriver/socket/HTTPServerSocket.cpp: (WebDriver::HTTPRequestHandler::packHTTPMessage const): * WebDriverTests/imported/w3c/webdriver/tests/classic/get_title/get.py: (test_strip_and_collapse): (test_title_included_entity_references): (test_title_included_multibyte_char): Canonical link: https://commits.webkit.org/279767@main
mnutt
pushed a commit
to movableink/webkit
that referenced
this pull request
Aug 27, 2024
…retrieved correctly https://bugs.webkit.org/show_bug.cgi?id=270063 Reviewed by Alexey Proskuryakov. If the document title contains multibyte characters such as Japanese or entity references, the "Get Title" result will be garbled. The title string is obtained by JavaScript's "document.title()", and this data is encoded in UTF8. However, the StringBuilder.append() function used to create HTTP messages uses fromLatin1() internally to generate strings from byte data. This seems to be causing the multibyte characters to be garbled. This patch changes to use String::fromUTF8() before concatenation to restore the correct WTF::String even if it contains multibyte characters. Also, the change of get.py is regression test for this issue. This is an export from web-platform-tests/wpt#46584. * Source/WebDriver/socket/HTTPServerSocket.cpp: (WebDriver::HTTPRequestHandler::packHTTPMessage const): * WebDriverTests/imported/w3c/webdriver/tests/classic/get_title/get.py: (test_strip_and_collapse): (test_title_included_entity_references): (test_title_included_multibyte_char): Canonical link: https://commits.webkit.org/279767@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for <title> tag values containing multibyte characters, such as entity references and CJK languages.
We want to use these tests to confirm bugs reported in WebKit https://bugs.webkit.org/show_bug.cgi?id=270063.