-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compat features for masonry and subgrid #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
I do agree we need a parent feature to group grid, subgrid, and masonry.
Finding a name that resonates with people might prove challenging...
Grid without masonry and subgrid has been around for long enough and has been documented/promoted enough that people know what the term "grid" refers to.
At the same time, I can't come up with another term for the parent group. It feels weird to invent something new because even if subgrid and masonry were not part of the initial grid implementation, they're technically only grid features, not something else.
Maybe that means the parent group should be called grid, and we should find another term for https://github.com/web-platform-dx/feature-set/blob/main/feature-group-definitions/grid.yml ?
Sorry if this was discussed already or is obviously a bad idea, but how about using version numbers? Grid without subgrid was spec'd in v1. Subgrid was spec'd in v2. How about renaming the current grid to grid-v1, and then the parent would be grid:
- grid
- grid-v1
- masonry
- subgrid
an alternative to version numbers might be years - e.g. "grid-2022" would refer to CSS Grid as would have been understood in 2022 (or whatever years makes this least ambiguous); when in 202X, most people would understand CSS Grid to include masonry and subgrid (but doesn't include the new fancy supergrid and rotary extensions), we would coin a new grid-202x name? (that would imply we wouldn't coin the "parent" feature until 202x, which may or may not work well) |
I also agree we'll need a parent feature, but I don't really think it matters. At least now, it's a pointless feature to give a name or list on caniuse.com. At some point in the future all of the Grid features might make sense to call just "Grid", but not now. I think this is a case of how we're going to evolve the feature hierarchy over time. Perhaps right it should be:
And eventually it will be:
|
Thanks for the reviews, everyone! Three comments, one from each of you, ties something interesting together:
I think these three comments share a common theme: some groups-of-groups are going to feel artificial because they don't (yet) describe something immediately relevant to web developers. Some groups of groups won't have that feeling, but the ones that do are a problem for us. This suggests a few things to me:
|
Totally agree with this. |
This is a follow up to #78. It adds a group for
masonry
and adds compat data for both it andsubgrid
.A natural follow up to this would be to introduce a structured way of describing the relationship between these features (i.e., that "classical" grid, subgrid, and masonry are each members of a common omnibus grid group).
cc: @captainbrosset