Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add File API #2378

Merged
merged 9 commits into from
Dec 19, 2024
Merged

Add File API #2378

merged 9 commits into from
Dec 19, 2024

Conversation

autonome
Copy link
Collaborator

@autonome autonome commented Dec 2, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Dec 2, 2024
@autonome autonome marked this pull request as ready for review December 3, 2024 15:22
@autonome
Copy link
Collaborator Author

autonome commented Dec 3, 2024 •
edited
Loading

A couple of notes:

  • The name seems a bit bare, and this is often referred to as "the File API" so we could put API in there if someone feels strongly about it
  • The name also doesn't center the entry point, which is FileList... seems odd but I've never seen anyone really talk about this like "the FileList API", so I dug around the internet and didn't see any evidence of anyone doing so
  • Re entry point - I put File key in the computed status as a node to the relation, but maybe that isn't needed

jamesnw
jamesnw reviewed Dec 3, 2024
View reviewed changes
features/file.yml Outdated Show resolved Hide resolved
jamesnw
jamesnw approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on the line about the name, with a slight preference for "File API", but will defer to others.

@autonome autonome requested a review from ddbeck December 16, 2024 16:16
ddbeck
ddbeck approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think this is ready to go, but I'd like to suggest a pretty significant rewrite of the description. Take a look and merge (or ask for re-review) at your convenience.

features/file.yml Outdated Show resolved Hide resolved
@autonome @ddbeck
Update features/file.yml
577e711 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@autonome autonome merged commit 2ac1adb into web-platform-dx:main Dec 19, 2024
3 checks passed
@autonome autonome deleted the fileapi branch December 19, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesnw jamesnw jamesnw approved these changes

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autonome @ddbeck @jamesnw