Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-sass): additionalData function type #2708

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix(plugin-sass): additionalData function type #2708

merged 2 commits into from
Jun 26, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Fix sass-loader's additionalData function type.

Related Links

close #2582

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Jun 26, 2024 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 6343911
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/667bb056998878000887a02d
😎 Deploy Preview https://deploy-preview-2708--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 86 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 71c66e6 into main Jun 26, 2024
10 checks passed
@chenjiahan chenjiahan deleted the sass_type_0626 branch June 26, 2024 06:37
@chenjiahan chenjiahan mentioned this pull request Jul 2, 2024
Merged
@CPatchane
Copy link

@chenjiahan According to https://github.com/webpack-contrib/sass-loader?tab=readme-ov-file#additionaldata, it can also be just a string.
With this change, it can only be a function.

@chenjiahan
Copy link
Member Author

my mistake, I will fix it

@chenjiahan chenjiahan mentioned this pull request Jul 12, 2024
Merged
2 tasks
@CPatchane
Copy link

FYI I suggested a PR to fix that on DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#70037

@chenjiahan
Copy link
Member Author

Nice 👍🏻

@CPatchane
Copy link

FYI I suggested a PR to fix that on DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#70037

It has been merged an release in the last version of @types/sass-loader 🎉

@chenjiahan
Copy link
Member Author

Awesome, can you submit a PR to bump version and remove the override types? ❤️

@chenjiahan
Copy link
Member Author

I think Rsbuild can still retain the type overrides, as @types/sass-loader depends on webpack.LoaderContext but Rsbuild should use Rspack.LoaderContext.

@chenjiahan chenjiahan mentioned this pull request Aug 6, 2024
Merged
2 tasks
@CPatchane
Copy link

Thanks for the changes 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Type of sass-loader additionalData function is wrong
2 participants
@chenjiahan @CPatchane